舉槍消滅"爛代碼"的實(shí)戰(zhàn)案例

JiaXinYi 發(fā)布于2019-07-01 10:31 / 741人閱讀

摘要：前言之前我寫過一篇如何少寫爛代碼感覺很多新人對此不太理解。今天以打卡功能為例去講解其中的奧秘。那篇文章講過代碼開發(fā)的過程中分幾種類型。增刪改的需求查的需求經(jīng)過多次實(shí)際開發(fā)驗(yàn)證后，發(fā)現(xiàn)完全是多次一舉。所以在這里更正下，取消。

前言

之前我寫過一篇如何少寫PHP "爛"代碼 https://segmentfault.com/a/11...
感覺很多新人對此不太理解。今天以打卡功能為例,去講解其中的奧秘。那篇文章講過代碼開發(fā)的過程中分幾種類型。

增刪改的需求

Route -> Controller -> Service -> Action

查的需求

Route -> Controller -> Service -> Repository

經(jīng)過多次實(shí)際開發(fā)驗(yàn)證后，發(fā)現(xiàn)Repository完全是多次一舉。所以在這里更正下，取消Repository。

Route -> Controller -> Service

打卡系統(tǒng)邏輯架構(gòu)圖

需求是這樣的，用戶每天打卡獲得積分，積分計(jì)入用戶賬戶,并且需記錄用戶積分的獲取及消費(fèi)情況。如圖所示，請求到控制器后，通過控制器去調(diào)用服務(wù)，服務(wù)又調(diào)用創(chuàng)建用戶打卡模塊完成打開，在用戶打卡過程中對用戶賬戶積分進(jìn)行變更及記錄用戶積分獲取記錄。

數(shù)據(jù)表結(jié)構(gòu) 打卡數(shù)據(jù)表

CREATE TABLE `member_attendance` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `member_id` int(11) NOT NULL COMMENT "用戶編碼",
  `status` enum("0","1") COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT "0" COMMENT "1簽到成功",
  `created_at` timestamp NULL DEFAULT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=8 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

用戶錢包表

CREATE TABLE `wallet` (
  `user_id` bigint(20) NOT NULL COMMENT "用戶標(biāo)示",
  `balance` decimal(12,2) NOT NULL COMMENT "錢包余額",
  `integral` decimal(12,2) NOT NULL DEFAULT "0",
  `add_time` int(11) NOT NULL COMMENT "添加時(shí)間",
  `update_time` int(11) NOT NULL COMMENT "更改時(shí)間",
  UNIQUE KEY `wallet_user_id_unique` (`user_id`),
  KEY `wallet_user_id_index` (`user_id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

用戶積分交易記錄表

CREATE TABLE `member_integral_detail` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `member_id` int(11) NOT NULL COMMENT "用戶編碼",
  `title` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT "來源或消費(fèi)",
  `integral` decimal(12,2) NOT NULL DEFAULT "0.00" COMMENT "積分?jǐn)?shù)",
  `type` tinyint(4) NOT NULL DEFAULT "0" COMMENT "類型 0收入 -1支出",
  `created_at` timestamp NULL DEFAULT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=8 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

具體業(yè)務(wù)實(shí)現(xiàn) Route

$api->post ("user/attendance","UserController@attendance");

MemberController

public function attendance()
{
    $result = $this->userService->attendance ($this->request);
            
    if ($result) {
        return $this->response->array (Response::return (200, "打卡成功"));
    }
            
    return $this->response->array (Response::return (0, "打卡失敗或已打卡"));        
}

MemberService

public function attendance($request)
{
    return (new CreateUserAttendance())->execute ($request);
}

CreateUserAttendance

public function issetToday($userId)
{
    $result = MemberAttendance::where ([
        ["member_id", "=", $userId],
    ])
        ->whereDate ("created_at", date ("Y-m-d", time ()))
        ->exists ();
    return $result;
}
// -------------------- 上述是下方issetToday方法，寫在MemberModel中
class CreateUserAttendance
{
    public function execute($data)
    {
            
        if ((new MemberAttendance())->issetToday ($data->user_id)) {
            return false;
        }
        
        $models            = new MemberAttendance();
        $models->member_id = $data->user_id;
        $models->status    = (string)"1";
            
        $result = $models->save ();
            
        if ($result) {
            (new CreateUserIntegralDetail())->execute ($data->user_id, "打卡", 10, 0);
            return true;
        }
            
        return false;
    }
}

CreateUserIntegralDetail

interface integralDetail
{
    public function execute($userId, $title, $integral, $type);
}
    
class CreateUserIntegralDetail extends UpdateUserWalletIntegral implements integralDetail
{
    public function execute($userId, $title, $integral, $type)
    {
        parent::exec ($userId, $integral, $type);
            
        $models            = new MemberIntegralDetail();
        $models->member_id = $userId;
        $models->title     = $title;
        $models->integral  = $integral;
        $models->type      = $type;
            
        return $models->save ();
    }
}

上述代碼繼承了更新用戶積分的動作，在每次打卡成功后，我們調(diào)用父類方法直接更新用戶積分。

UpdateUserWalletIntegral

class UpdateUserWalletIntegral
{
    public function exec($userId, $integral, $type)
    {
        if ($type == 0) {
            Wallet::where (["user_id", "=", $userId])->increment ("integral", $integral);
        } else {
            Wallet::where (["user_id", "=", $userId])->decrement ("integral", $integral);
        }
    }
}

致謝

感謝你看到這里，希望本篇文章可以幫到你。有什么問題可在下方評論區(qū)留言。謝謝